Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.z] Backport of Strimzi Kafka testcontainer #1228

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Jul 24, 2024

Summary

Backport of strimzi update

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Backport
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97
Copy link
Member Author

jedla97 commented Jul 24, 2024

@fedinskiy looking at this branch and in #1189 this PR #1191 wasn't added. Do you remember if it's needed or not? Backport to 1.4.z have it #1190

@jedla97 jedla97 requested a review from fedinskiy July 24, 2024 16:07
@fedinskiy
Copy link
Contributor

@jedla97 the PR should protect against the same bug it our code, so it is worth adding. Could you either cherry-pick the commit, or just manually do -t=${KAFKA_CLUSTER_ID} change?

fedinskiy and others added 2 commits July 25, 2024 09:25
Adds detailed output and hopefully fixes this error:
quarkus-qe#1186

(cherry picked from commit 70dfa22)
@jedla97
Copy link
Member Author

jedla97 commented Jul 25, 2024

@fedinskiy I cherry-pick the commit now it should be done

@fedinskiy
Copy link
Contributor

run tests

@fedinskiy fedinskiy merged commit 1b50657 into quarkus-qe:1.3.z Jul 26, 2024
9 checks passed
@jedla97 jedla97 deleted the 1.3-bump-strimzi branch July 26, 2024 11:22
@gtroitsk gtroitsk mentioned this pull request Sep 9, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants