-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Quarkus CLI TLS command #1268
Add support for Quarkus CLI TLS command #1268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, just 2 minor things that are not mandatory for merging.
I will wait till CI is done.
quarkus-test-cli/src/main/java/io/quarkus/test/bootstrap/AbstractCliCommand.java
Outdated
Show resolved
Hide resolved
quarkus-test-cli/src/main/java/io/quarkus/test/bootstrap/QuarkusCliClient.java
Show resolved
Hide resolved
Just FYI I run all related tests locally so I hope it will be fine. But sure, no merging till it's green. |
4566961
to
87abd7e
Compare
|
|
|
The cause is here: |
it needs Quarkus TLS Registry extension, which is present though. I'll find the difference and write it here. |
I have reproduced it in brand new fork few times. Funny business, it seems that same command fails depending on parent directories of a Quarkus application created with CLI command. Then I deleted that fork and started a new fork and can't reproduce it again. There is probably some algorithm to it. I'll try to find reproducer. |
87abd7e
to
ac2e78b
Compare
What I have changed is to perform test in temporary directory instead. I hope it's alright for now. |
Okay, I am thinking it is about some lock when the command is first executed during test because I cannot reproduce it outside of it. |
CI is green, merging. |
Summary
We need to test https://quarkus.io/guides/tls-registry-reference#quarkus-cli-commands-and-development-ca-certificate-authority so adding few convenient methods to facilitate testing.
Please check the relevant options
run tests
phrase in comment)Checklist: