Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PEM certificate generation with disabled TLS registry #1281

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 4, 2024

Summary

Spotted here quarkus-qe/quarkus-test-suite#1972. Fixes:

2024-09-04T18:52:01.7918327Z java.lang.IllegalArgumentException: TLS registry is enabled but TLS config name is null
2024-09-04T18:52:01.7919973Z 	at io.quarkus.test.security.certificate.Certificate.tlsConfigPropPrefix(Certificate.java:343)
2024-09-04T18:52:01.7922131Z 	at io.quarkus.test.security.certificate.Certificate.configurePemConfigurationProperties(Certificate.java:260)
2024-09-04T18:52:01.7925082Z 	at io.quarkus.test.security.certificate.Certificate.of(Certificate.java:240)
2024-09-04T18:52:01.7926413Z 	at io.quarkus.test.security.certificate.Certificate.ofInterchangeable(Certificate.java:78)
2024-09-04T18:52:01.7928174Z 	at io.quarkus.test.security.certificate.Certificate.of(Certificate.java:83)
2024-09-04T18:52:01.7929854Z 	at io.quarkus.test.services.containers.SqlServerManagedResourceBuilder.build(SqlServerManagedResourceBuilder.java:41)
2024-09-04T18:52:01.7931404Z 	at io.quarkus.test.bootstrap.BaseService.init(BaseService.java:304)
2024-09-04T18:52:01.7932812Z 	at io.quarkus.test.bootstrap.QuarkusScenarioBootstrap.initService(QuarkusScenarioBootstrap.java:235)
2024-09-04T18:52:01.7934674Z 	at io.quarkus.test.bootstrap.QuarkusScenarioBootstrap.initResourceFromField(QuarkusScenarioBootstrap.java:202)
2024-09-04T18:52:01.7936595Z 	at io.quarkus.test.bootstrap.QuarkusScenarioBootstrap.lambda$beforeAll$1(QuarkusScenarioBootstrap.java:64)
2024-09-04T18:52:01.7937958Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2024-09-04T18:52:01.7939245Z 	at io.quarkus.test.bootstrap.QuarkusScenarioBootstrap.beforeAll(QuarkusScenarioBootstrap.java:64)
2024-09-04T18:52:01.7940918Z 	at io.quarkus.test.bootstrap.QuarkusScenarioBootstrap.beforeAll(QuarkusScenarioBootstrap.java:50)
2024-09-04T18:52:01.7942246Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik changed the title Fix PEM certificate generation without TLS registry Fix PEM certificate generation with disabled TLS registry Sep 4, 2024
@michalvavrik michalvavrik added the triage/backport-1.5? Quarkus 3.15 stream label Sep 4, 2024
@gtroitsk gtroitsk merged commit e3863ec into quarkus-qe:main Sep 4, 2024
5 checks passed
@michalvavrik michalvavrik mentioned this pull request Sep 4, 2024
11 tasks
@michalvavrik michalvavrik deleted the feature/fix-pem-without-tls-registry branch September 4, 2024 20:46
@michalvavrik michalvavrik removed the triage/backport-1.5? Quarkus 3.15 stream label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants