Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenShiftOracleDatabaseIT as not supported scenario #757

Merged

Conversation

michalvavrik
Copy link
Member

Summary

related to quarkus-qe/quarkus-test-suite#1163 and quarkus-qe/quarkus-test-suite#246

According to https://issues.redhat.com/browse/QUARKUS-1164, using Oracle in OpenShift is not supported scenario. Creating Oracle container always end with error Error: container create failed: time="2023-04-22T09:30:48Z" level=error msg="runc create failed: unable to start container process: exec /opt/oracle/container-entrypoint.sh: permission denied" and elevating user privilege don't help. I only found very indirect hints that we would need to customize container (see gvenzl/oci-oracle-xe#145 and https://www.ibm.com/docs/en/order-management-sw/10.0?topic=SS6PEW_10.0.0/installation/c_OMRHOC_deploy_for_oracle.htm). I think customizations would mean that customer would lose Oracle support too, therefore such tests has no value for us.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from mjurc April 22, 2023 10:21
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently have no means of testing connection with Oracle DB out of OpenShift on OpenShift tests.

@mjurc mjurc merged commit 6be01ab into quarkus-qe:main Apr 24, 2023
@michalvavrik michalvavrik deleted the feature/remove-oracle-ocp-test-coverage branch April 24, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants