Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Quarkus version to 3.0.3.Final #774

Merged
merged 2 commits into from
May 12, 2023
Merged

Bump Quarkus version to 3.0.3.Final #774

merged 2 commits into from
May 12, 2023

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented May 5, 2023 •
edited
Loading

Summary

Bumps Quarkus version to 3.0.3.Final.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik requested review from rsvoboda and fedinskiy and removed request for rsvoboda May 5, 2023 21:03
fedinskiy
fedinskiy approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But please, take a look at CI failure

@michalvavrik
Copy link
Member Author

But please, take a look at CI failure

I'll re-run them and then I'll look again. Can't reproduce this locally.

@michalvavrik
Copy link
Member Author

Yeah, it is related. I will work on it, not sure why I didn't reproduce it previously.

@michalvavrik michalvavrik force-pushed the feature/bump-quarkus-to-3.0.2.Final branch from 7b64400 to 23d299a Compare May 11, 2023 21:03
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik changed the title Bump Quarkus version to 3.0.2.Final Bump Quarkus version to 3.0.3.Final May 12, 2023
@michalvavrik
Copy link
Member Author

Okay, so failures are my fault as I merged #771 and didn't mention 7.4.0 is not compatible with native. I confirmed that everything works with io.confluent:kafka-avro-serializer:7.3.3 although https://quarkus.io/guides/kafka-schema-registry-avro#confluent explicitly mention that only 7.2.x and lower are guaranteed to work in native. Therefore I'll revert that change and push it here because I don't feel comfortable to merging this without green CI.

@michalvavrik
Revert "Bump kafka-avro-serializer from 7.3.3 to 7.4.0"
78f214d 
This reverts commit a5827c7 as Quarkus not compatible with 7.4.x so far. Documented support in native only includes 7.2.x, but as we already know 7.3.x works, I dare to stick with it.
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik merged commit 692b6ed into quarkus-qe:main May 12, 2023
@michalvavrik michalvavrik deleted the feature/bump-quarkus-to-3.0.2.Final branch May 12, 2023 13:11
@michalvavrik michalvavrik mentioned this pull request May 16, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedinskiy fedinskiy fedinskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @fedinskiy