Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test OpenShift serving certificates and TLS registry with REST client #1987

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 6, 2024

Summary

This is quite similar to what I have done in QE Test Framework quarkus-qe/quarkus-test-framework#1270 because I think it tests all we need from TLS Registry integration with REST client and OpenShift certificate serving. Few differences:

  • test native as well; what we want to test in native is:
  • here it is tested that both HTTP server and REST client are configured with TLS version configured in TLS registry and they do require it

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/openshift-cert-serving-with-rest-clients branch from 816c3f4 to d6b077f Compare September 6, 2024 13:29
@michalvavrik
Copy link
Member Author

run tests

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, LGTM

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

michalvavrik commented Sep 6, 2024

Native failed over Caused by: java.security.cert.CertificateException: No subject alternative DNS name matching server.ts-jblpfaeiqm.svc.cluster.local found which is the original reason why I added untilAsserted. I think it is just flaky and we should add couple of seconds to waiting as it depends on OpenShift and not us. Let me add few seconds and retry.

@michalvavrik michalvavrik force-pushed the feature/openshift-cert-serving-with-rest-clients branch from d6b077f to 1994a5f Compare September 6, 2024 18:36
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

yeah, OCP is green now so I'll merge it.

@michalvavrik michalvavrik merged commit 3294899 into quarkus-qe:main Sep 6, 2024
10 checks passed
@michalvavrik michalvavrik deleted the feature/openshift-cert-serving-with-rest-clients branch September 6, 2024 19:43
@fedinskiy
Copy link
Contributor

FYI: our weekly runs now fail due to : java.security.cert.CertificateException

@michalvavrik
Copy link
Member Author

FYI: our weekly runs now fail due to : java.security.cert.CertificateException

thanks, I'll look. this seems like OCP setup or longer waiting, I don't know what could change in code to avoid this, but let see

@michalvavrik
Copy link
Member Author

in OpenShift they say that pod won't start until secret is mounted, so I think I need to inspect what is actually mounted in cases when it fails and whether it is retry or just randomness that is makes it sometimes fail and sometimes pass

@michalvavrik
Copy link
Member Author

it's not quite easy to reproduce, didn't happen to me once so far :-( maybe it is more likely to happen when OpenShift cluster is busy, don't know.

@michalvavrik
Copy link
Member Author

I figured it out: quarkus-qe/quarkus-test-framework#1296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants