Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should use -Dno-format to execute other plugins too #29758

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Dec 8, 2022

The impsort plugin is never triggered. Instead of adding it, the build should simply reuse the existing profiles that are already declared in the quarkiverse-parent.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Dec 8, 2022
@gastaldi gastaldi force-pushed the build_quarkiverse branch 2 times, most recently from fda2cfd to 8ada917 Compare December 8, 2022 14:54
@turing85
Copy link
Contributor

turing85 commented Dec 8, 2022

@gastaldi and I discussed to move native tests in a separate step. This has the benefit that the native tests (and thus the native compilation) is executed if and only if all JVM-tests were successful. on the native step, re-run of JVM tests is suppressed through ... Dnative.surefire.skip.

@quarkus-bot

This comment has been minimized.

@gastaldi gastaldi added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Dec 9, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 9, 2022

Failing Jobs - Building a74d91a

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@gastaldi gastaldi merged commit f3779d7 into quarkusio:main Dec 9, 2022
@gastaldi gastaldi deleted the build_quarkiverse branch December 9, 2022 20:05
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 9, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 9, 2022
@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants