Provide new API to programmatically create REST Client reactive #32857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll need a resolution on #32856 (comment) before moving this forward |
|
🙈 The PR is closed and the preview is expired. |
geoand
reviewed
Apr 24, 2023
...reactive/runtime/src/main/java/io/quarkus/rest/client/reactive/QuarkusRestClientBuilder.java
Outdated
Show resolved
Hide resolved
| * @return the current builder with the connect timeout set. | ||
| * @throws IllegalArgumentException if the value of timeout is negative. | ||
| */ | ||
| QuarkusRestClientBuilder readTimeout(long timeout, TimeUnit unit); |
There was a problem hiding this comment.
We should probably also have tests where these properties override the configured values in application.properties
There was a problem hiding this comment.
This is covered by RestClientCDIDelegateBuilderTest
This comment has been minimized.
This comment has been minimized.
geoand
reviewed
Apr 25, 2023
The new API includes these additional options: - verifyHost - trustStore by truststore and password (it was requested in quarkusio#31891) - proxyUser - proxyPassword - nonProxyHosts Fix quarkusio#32856
geoand
added
the
triage/waiting-for-ci
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new API includes these additional options:
Note that for the new API, I didn't add any breaking change, so users can keep using the Microprofile one.
Fix #32856