Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear the VertxMDC ThreadLocal when shutting down Vert.x #41724

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Clear the VertxMDC ThreadLocal when shutting down Vert.x #41724

merged 1 commit into from
Jul 6, 2024
+1 −0

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jul 6, 2024

I saw it appearing a few times in my heap dumps.

@gsmet gsmet requested a review from cescoffier July 6, 2024 09:38
cescoffier
cescoffier approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great catch!

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 6, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c59049c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 39a3331 into quarkusio:main Jul 6, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/vertx
Projects
None yet
Milestone
3.13.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@gsmet @cescoffier