Enable dev services to be located by in-container java #41858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Integration tests need more awareness that native image agent integration tests run Quarkus in container, therefore any dev services need to be tweaked so that the java process in container can locate them. * Tweaked the existing native image agent test in order to run an ORM/postgresql test that fails without this fix.
This comment has been minimized.
This comment has been minimized.
geoand
reviewed
Jul 15, 2024
Comment on lines
+200
to
+201
| boolean isDockerLaunch = isContainer(artifactType) | ||
| || (isJar(artifactType) && "test-with-native-agent".equals(testProfile)); |
There was a problem hiding this comment.
Is there any way we can be avoid hardcoding the agent here?
There was a problem hiding this comment.
Hmmm, not sure with the current code base. Docker/container handling code is scattered around in many places. This is another example of surgery we have to keep doing to handle different container build/run setups.
There was a problem hiding this comment.
Okay, let's keep as is for now and we can figure out something better the next time we hit this
Status for workflow
|
geoand
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41771
fails without this fix.
quarkus-resteasytoquarkus-restcauses the existing tests to fail with the 404 body message, so removed the body check. Status code check is enough.