Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Micrometer and OpenTelemetry to the WebSockets Next extension #41956

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Integrate Micrometer and OpenTelemetry to the WebSockets Next extension #41956

wants to merge 1 commit into from

Conversation

michalvavrik
Copy link
Member

closes: #39143

@gsmet gsmet requested review from geoand, mkouba and brunobat July 17, 2024 15:55
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@michalvavrik
Copy link
Member Author

Crickey, I just mentioned that #39143 (comment) wants messages per connection and destination. Missed it till now. I'll make this draft and try to address it ASAP.

@michalvavrik michalvavrik marked this pull request as draft July 17, 2024 16:31
@michalvavrik michalvavrik marked this pull request as ready for review July 20, 2024 20:26
@michalvavrik
Copy link
Member Author

I think this is ready for review.

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@michalvavrik michalvavrik force-pushed the feature/ws-next-otel branch 2 times, most recently from 7c325ce to 22b00b4 Compare July 21, 2024 09:28
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
geoand
geoand reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@brunobat
Copy link
Contributor

Checking out the PR and Reviewing now... Will take some time. It's a biggie :)

@michalvavrik michalvavrik force-pushed the feature/ws-next-otel branch 2 times, most recently from 91e5b03 to dbbe900 Compare July 24, 2024 18:04
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@michalvavrik
Copy link
Member Author

to address agreed changes for on connection opened traces/metrics, I'll need to make further changes that are wip atm so it makes no sense to review now. I'll make this PR a draft and try to finish it tomorrow. thanks for reviews so far

@michalvavrik michalvavrik marked this pull request as draft July 24, 2024 22:54
@michalvavrik michalvavrik marked this pull request as ready for review July 25, 2024 13:49
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@michalvavrik
Copy link
Member Author

@mkouba @brunobat I believe I have addressed all your requests / comments and this PR is ready for a next round of reviews

@michalvavrik michalvavrik force-pushed the feature/ws-next-otel branch 2 times, most recently from a01b3d2 to fc21e37 Compare July 25, 2024 15:42
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet
Copy link
Member

gsmet commented Aug 8, 2024

@mkouba we are close to the cut-off for features that will be in 3.14 and 3.15 LTS. So if you want this in, we will have to merge it very very soon as in before next Tuesday :).

@mkouba
Copy link
Contributor

mkouba commented Aug 8, 2024

@mkouba we are close to the cut-off for features that will be in 3.14 and 3.15 LTS. So if you want this in, we will have to merge it very very soon as in before next Tuesday :).

@gsmet I'm pretty sure we won't make it :-(

This is a massive PR that needs a detailed review. I will meet with Michal by the end of August.

@brunobat
Copy link
Contributor

@mkouba we are close to the cut-off for features that will be in 3.14 and 3.15 LTS. So if you want this in, we will have to merge it very very soon as in before next Tuesday :).

@gsmet I'm pretty sure we won't make it :-(

This is a massive PR that needs a detailed review. I will meet with Michal by the end of August.

Please include me.

@michalvavrik
Copy link
Member Author

Rebased on current main as this was pretty old now.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 27, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 53805a4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

@github-actions GitHub Actions
Copy link

🎊 PR Preview 2ca2703 has been successfully built and deployed to https://quarkus-pr-main-41956-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 27, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 53805a4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand left review comments

@mkouba mkouba Awaiting requested review from mkouba

@brunobat brunobat Awaiting requested review from brunobat

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/documentation area/metrics area/tracing area/websockets triage/flaky-test
Projects
Quarkus Documentation
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebSockets Next: OTel integration
5 participants
@michalvavrik @brunobat @gsmet @mkouba @geoand