Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuarkusTestProfile overrides in a high ordinal application.properties #41957

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Jul 17, 2024

This sets the QuarkusTestProfile config overrides as a high ordinal application.properties, available as an additional resource to the Quarkus test application. This should solve a couple of issues:

  • Test config overrides are now properly isolated
  • The test config now overrides sources higher than System (this is not possible now, without additional changes out of scope of the issue / PR). System properties are being mutated to pass around configuration, and it shouldn't. We need to fix that first.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 18, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4a1abd0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:821)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼

@radcortez radcortez merged commit 5dcf5f3 into quarkusio:main Jul 30, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test profile config properties can bleed into other test profiles
2 participants