Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute template records: fix the way the canonical constructor is found #42439

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Qute template records: fix the way the canonical constructor is found #42439

merged 1 commit into from
Aug 9, 2024
+93 −71

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Aug 9, 2024

@mkouba mkouba requested review from gastaldi and Ladicek August 9, 2024 07:27
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Aug 9, 2024
mkouba
mkouba commented Aug 9, 2024
View reviewed changes
extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteProcessor.java
Type[] componentTypes = recordClass.recordComponents().stream().map(RecordComponentInfo::type)
.toArray(Type[]::new);
MethodInfo canonicalConstructor = recordClass.method(MethodDescriptor.INIT, componentTypes);
MethodInfo canonicalConstructor = recordClass.method(MethodDescriptor.INIT,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot use the new ClassInfo#canonicalRecordConstructor() here because we need to get this into 3.8.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad :-)

Ladicek
Ladicek approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about the commented assertion.

@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
Qute template records: fix the way the canonical constructor is found
c05d0b1 
- also fix the problem with compact record constructor
- resolves quarkusio#42411
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 9, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c05d0b1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 48ecb86 into quarkusio:main Aug 9, 2024
42 of 43 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 9, 2024
@gsmet gsmet modified the milestones: 3.14.0.CR1, 3.13.3 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@gastaldi gastaldi Awaiting requested review from gastaldi

Assignees
No one assigned
Labels
area/qute The template engine kind/bugfix triage/backport-3.8
Projects
None yet
Milestone
3.13.3
Development

Successfully merging this pull request may close these issues.

Qute template records: fix the way the canonical constructor is found
3 participants
@mkouba @Ladicek @gsmet