Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable the extension annotation processor for default-compile #42443

Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 9, 2024

This is a followup of the previous PR as this change was already partially implemented but my search/replace missed some of them.

This should be a lot more consistent (even if there are still a few modules that are a bit odd).

Fixes #42419

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 9, 2024

/cc @loicmathieu (elasticsearch), @marko-bekhta (elasticsearch), @yrodiere (elasticsearch,hibernate-orm)

This is a followup of the previous PR as this change was already
partially implemented but my search/replace missed some of them.

This should be a lot more consistent (even if there are still a few
modules that are a bit odd).

Fixes quarkusio#42419
@gsmet gsmet force-pushed the annotation-processor-only-default-compile branch from 29f0ab6 to 4e11ab3 Compare August 9, 2024 12:26
@gsmet gsmet marked this pull request as ready for review August 11, 2024 09:23
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4e11ab3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet requested a review from gastaldi August 11, 2024 16:36
@gastaldi gastaldi merged commit 17f09ee into quarkusio:main Aug 11, 2024
63 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment