-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codestart modularize pom #42574
base: main
Are you sure you want to change the base?
Codestart modularize pom #42574
Conversation
This comment has been minimized.
This comment has been minimized.
It looks good. The only thing I would prefer to avoid is the ignored dependencies, it is very specific to your case and will introduce complexity. Let's find another solution to this. |
What I suggest is making the dependencies also modular and use the ignore in your overridden template. |
ok let me propose a new version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
I think we are complete. I am going to squash and rebase. thanks for the review. I tested it on my project, with my override and that works out nicely. |
ff4114b
to
e963291
Compare
@ia3andy squashed, rebased and re-tested. |
e963291
to
4ba5000
Compare
Status for workflow
|
split pom file into multiple fragments.
introduce data variables to control what is included.
optionally not include a particular artifact dependency (in case it is already inherited from another known extension)
optionally not include a version for a particular artifact dependency (in case some common dependencies are from dependency mgmt).
in our case, we would overidde the
codestart.yml
with:explanation:
quarkus-arc
in new projects)see the zulip discussion