-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort the list of endpoints in the generated dev 404 #43128
Conversation
.../runtime/src/main/java/io/quarkus/vertx/http/runtime/devmode/AdditionalRouteDescription.java
Outdated
Show resolved
Hide resolved
5ec70b9
to
b9610c8
Compare
@@ -124,8 +124,12 @@ public String getHTMLContent() { | |||
|
|||
// Additional Endpoints | |||
if (!this.additionalEndpoints.isEmpty()) { | |||
List<AdditionalRouteDescription> endpoints = this.additionalEndpoints.stream().sorted( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it's the same for all 3 media types, you can probably extract this logic into a private method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b9610c8
to
2d28d32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks !
Status for workflow
|
Relates to: #42827
Updated
compareTo
method inAdditionalRouteDescription
to sort endpoints by the number of/
first, and lexicographically if the counts are equal.