Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mdx-code-block special code block for docusaurus #8339

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Jan 18, 2024

It is not handled by docusaurus if there is whitespace after backtick like pandoc is creating from CodeBlock

This fixes #8333

Though from discussion there, it could also be an issue in docusaurus itself that they should fix as it is breaking from V2 to V3
and it does not seem they mention this change as known (cc @eitsupi)

Their checker (https://github.com/slorber/docusaurus-mdx-checker) does not warn on the produced file with a space also

So opening as draft to keep this if we decide to merge it

…here is whitespace after backtick like pandoc is creating from CodeBlock
@cderv cderv requested a review from cscheid January 18, 2024 13:31
@cscheid
Copy link
Collaborator

cscheid commented Jan 18, 2024

I think we need to merge this because we're providing the translation of blocks like this into mdx-code-block blocks as a feature:

```{=mdx}
...
```

We don't want Quarto to regress regress here, independently of how brittle Docusaurus is on this respect.

@cderv
Copy link
Collaborator Author

cderv commented Jan 18, 2024

I agree, that is why I open the PR. I'll undraft and let you merge if we go for it for 1.4

I did not add a new tst by the way, but just adapted the existing one.

@cderv cderv marked this pull request as ready for review January 18, 2024 14:39
@cscheid cscheid merged commit ee7c66a into main Jan 18, 2024
47 checks passed
@cscheid cscheid deleted the docusaurus/mdx-block branch January 18, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docusaurus] {=mdx} code block seems broken (Quarto 1.4 with Docusaurus v3)
2 participants