fix/feat(vite-plugin): Improve and future-proof the transform checks #14151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are indirectly depending on it through the resource ids. So, if a new major version of it gets released before a new major version of Vite or vice-versa, we might not be able to support one or the other. Making it a peer dep will allows us to selectively support versions.
|
Tested locally with pnpm |
Shinigami92
approved these changes
Aug 9, 2022
|
@yusufkandemir Awesome work! Please confirm this has been tested with JS, with TS, with script setup, without script setup. |
|
@rstoenescu works with all those combinations, with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)Other information:
See vitejs/vite-plugin-vue#138 for the issue this PR aims to solve. See vitejs/vite-plugin-vue#138 for some insights behind the solution.
As a side-effect, we now support auto-importing separate files like
<template src="whatever.html">and<script src="test.js">which has been requested in #12319.