chore: better profiling support #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the delta pprof endpoints that pyroscope can make use of. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
This should allow for cross-referencing traces and profiles. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
This enables the mutex and blocking profiles and adds an escape hatch to disable or tune them for now. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
The `debug` profile will now also start a pyroscope instance configured to scrape the indexer and matcher. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
crozzy
approved these changes
Jul 7, 2023
|
another spurious |
|
I don't seem to be able to retrigger the failing check from the jenkins side, it's fine for me to merge without it, the issue should be fixed going forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes enable the "delta pprof" format supported by pyroscope, enables the mutex and blocking profiles by default, and adds pyroscope to the "debug"
docker-composeprofile.