Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the merge-multiple directive when downloading binaries #2058

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

crozzy
Copy link
Collaborator

@crozzy crozzy commented May 1, 2024

From the docs: When multiple artifacts are matched, this changes the behavior of the destination directories. If true, the downloaded artifacts will be in the same directory specified by path. If false, the downloaded artifacts will be extracted into individual named directories within the specified path.

So essentially, the artifacts were being downloaded into individual dirs and hence the release failure.

https://github.com/quay/clair/actions/runs/8912316665

@crozzy crozzy requested a review from a team as a code owner May 1, 2024 18:42
@crozzy crozzy requested review from hdonnay and removed request for a team May 1, 2024 18:42
@hdonnay
Copy link
Member

hdonnay commented Jun 6, 2024

Is this still needed?

@crozzy
Copy link
Collaborator Author

crozzy commented Jun 6, 2024

Yes, I believe so, had to do it manually in the last release IIRC, going to rebase

From the docs: When multiple artifacts are matched, this changes the behavior
of the destination directories. If true, the downloaded artifacts will be in
the same directory specified by path. If false, the downloaded artifacts will
be extracted into individual named directories within the specified path.

So essentially, the artifacts were being downloaded into different dirs
and hence the release failure.

Signed-off-by: crozzy <joseph.crosland@gmail.com>
@crozzy crozzy force-pushed the release-ci-download-artifact-behaviour branch from b9bf29f to 7d3f12e Compare June 6, 2024 15:07
@crozzy
Copy link
Collaborator Author

crozzy commented Jun 6, 2024

/fast-forward

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Triggered from #2058 (comment) by @​crozzy.

Trying to fast forward main (74b377b) to release-ci-download-artifact-behaviour (7d3f12e).

Target branch (main):

commit 74b377b8f9bf340c427025de0dfe9b02cfa094f4 (HEAD -> main, origin/main, origin/HEAD)
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed May 29 21:55:07 2024 +0000

    build(deps): bump github.com/rs/zerolog from 1.32.0 to 1.33.0
    
    Bumps [github.com/rs/zerolog](https://github.com/rs/zerolog) from 1.32.0 to 1.33.0.
    - [Commits](https://github.com/rs/zerolog/compare/v1.32.0...v1.33.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/rs/zerolog
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>

Pull request (release-ci-download-artifact-behaviour):

commit 7d3f12e34ef637d7f4a7682ebc0aba7e1ffe4210 (pull_request/release-ci-download-artifact-behaviour)
Author: crozzy <joseph.crosland@gmail.com>
Date:   Wed May 1 11:37:38 2024 -0700

    chore: use the merge-multiple directive when downloading binaries
    
    From the docs: When multiple artifacts are matched, this changes the behavior
    of the destination directories. If true, the downloaded artifacts will be in
    the same directory specified by path. If false, the downloaded artifacts will
    be extracted into individual named directories within the specified path.
    
    So essentially, the artifacts were being downloaded into different dirs
    and hence the release failure.
    
    Signed-off-by: crozzy <joseph.crosland@gmail.com>

Fast forwarding main (74b377b) to release-ci-download-artifact-behaviour (7d3f12e).

$ git push origin 7d3f12e34ef637d7f4a7682ebc0aba7e1ffe4210:main
To https://github.com/quay/clair.git
 ! [remote rejected]   7d3f12e34ef637d7f4a7682ebc0aba7e1ffe4210 -> main (refusing to allow a GitHub App to create or update workflow `.github/workflows/cut-release.yml` without `workflows` permission)
error: failed to push some refs to 'https://github.com/quay/clair.git'

@crozzy crozzy merged commit 7d3f12e into quay:main Jun 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants