Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nullable types in reflection values #186

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

paviad
Copy link
Contributor

@paviad paviad commented Mar 18, 2023

Fixes #185

Copy link
Owner

@r3c r3c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks! Feel free to merge, I'll take care of adding unit tests to cover this feature 🙂

@r3c
Copy link
Owner

r3c commented Mar 20, 2023

Sorry @paviad I just realized build & test checks were waiting for manual unlock. It should be good now 🙂

@paviad
Copy link
Contributor Author

paviad commented Mar 21, 2023

Not sure if you're talking to me or to other maintainers :) I cannot merge of course.

@r3c
Copy link
Owner

r3c commented Mar 21, 2023

Not sure if you're talking to me or to other maintainers :) I cannot merge of course.

OK then I failed to configure permissions properly, I would have expected you to be able to merge as soon as PR was approved, sorry for the confusion. I'll take care of adding tests and will ping here when a NuGet is released with your fix 🙂

@r3c r3c merged commit eab3e63 into r3c:master Mar 21, 2023
r3c added a commit that referenced this pull request Mar 21, 2023
r3c added a commit that referenced this pull request Mar 21, 2023
@r3c
Copy link
Owner

r3c commented Mar 21, 2023

Done and released in 2.0.9! Thanks again for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for nullable types in reflection value
2 participants