Optimisation

[dcorbacho]

• Use lists:keyfind instead of proplists to speed up the management stats
  Derives from Parallelise statistics DB collector rabbitmq-management#41

[michaelklishin]

@dcorbacho I'm sure this was a change driven by benchmarks used in rabbitmq/rabbitmq-management#41 but out of curiosity, how much difference does it make for this specific function, %-wise?

[dcorbacho]

@michaelklishin proplists is ~7x slower than lists. Querying the queues in management DB, for 62k queues it was called at least 824k times, so the improvement is noticeable.

Lists are a BIF, while proplists is not and does some verification on the structure of the list: https://github.com/erlang/otp/blob/maint/lib/stdlib/src/proplists.erl#L208

[michaelklishin]

Thanks for the clarification.

[michaelklishin]

This can be merged separately from the rest of management#41.