This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
Replace infinite timeouts with sensible defaults. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
suggested changes
Jun 15, 2017
include/amqp_client_internal.hrl
Outdated
| @@ -35,3 +35,6 @@ | |||
| {<<"consumer_cancel_notify">>, bool, true}, | |||
| {<<"connection.blocked">>, bool, true}, | |||
| {<<"authentication_failure_close">>, bool, true}]). | |||
|
|
|||
| -define(CALL_TIMEOUT, | |||
| rabbit_misc:get_env(amqp_client, gen_server_call_timeout, 30000)). | |||
There was a problem hiding this comment.
Since this is on the hot code path, we should probably do what we do in the server: in process caching of the timeout value, since all rabbit_misc:get_env/3 (application:get_env*) requests go through a single gen_server.
kjnilsson
force-pushed
the
rabbitmq-erlang-client-85
branch
from
e5fc1a2
to
1bb602e
Compare
Change gen_server:call timeouts to use a configurable default that is cached inside each process' process dictionary. Also make supervisor shutdown timeouts use the SUPERVISOR_WAIT value. [#147178169]
kjnilsson
force-pushed
the
rabbitmq-erlang-client-85
branch
from
1bb602e
to
2e75861
Compare
To match default server heartbeat timeout. While at it, increase initial connection timeout to 60s to match (heartbeat timeout doesn't matter here specifically but related in general).
michaelklishin
approved these changes
Jun 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change gen_server:call timeouts to use a configurable
default. Also make supervisor shutdown timeouts use
the SUPERVISOR_WAIT value.
Fixes #85.
[#147178169]