Compilation fails on OTP 19.0 #860

michaelklishin · 2016-06-26T15:20:37Z

There are two issues:

Uses of the (now removed) legacy type spec syntax
random is now deprecated. rand, however, is not a 100% drop-in replacement and is only available in OTP 18.0+.

For example:

src/file_handle_cache.erl:247: syntax error before: '/'
src/file_handle_cache.erl:248: syntax error before: '/'
src/file_handle_cache.erl:253: syntax error before: '/'
src/file_handle_cache.erl:258: syntax error before: '/'
src/file_handle_cache.erl:259: syntax error before: '/'
src/file_handle_cache.erl:261: syntax error before: '/'
src/file_handle_cache.erl:262: syntax error before: '/'
src/file_handle_cache.erl:263: syntax error before: '/'
src/file_handle_cache.erl:264: syntax error before: '/'
src/file_handle_cache.erl:265: syntax error before: '/'
src/file_handle_cache.erl:266: syntax error before: '/'
src/file_handle_cache.erl:267: syntax error before: '/'
src/file_handle_cache.erl:268: syntax error before: '/'
src/file_handle_cache.erl:270: syntax error before: '/'
src/file_handle_cache.erl:271: syntax error before: '/'
src/file_handle_cache.erl:272: syntax error before: '/'
src/file_handle_cache.erl:273: syntax error before: '/'
src/file_handle_cache.erl:274: syntax error before: '/'
src/file_handle_cache.erl:275: syntax error before: '/'
src/file_handle_cache.erl:276: syntax error before: '/'
src/file_handle_cache.erl:277: syntax error before: '/'
src/file_handle_cache.erl:278: syntax error before: '/'
src/file_handle_cache.erl:279: syntax error before: '/'
src/file_handle_cache.erl:280: syntax error before: '/'
src/file_handle_cache.erl:281: syntax error before: '/'
src/file_handle_cache.erl:282: syntax error before: '/'
src/file_handle_cache.erl:283: syntax error before: '/'
src/file_handle_cache.erl:284: syntax error before: '/'
src/file_handle_cache.erl:285: syntax error before: '/'
src/file_handle_cache.erl:286: syntax error before: '/'
src/file_handle_cache.erl:239: type ref() is unused
src/file_handle_cache.erl:240: type ok_or_error() is unused
src/file_handle_cache.erl:241: type val_or_error(_) is unused
src/file_handle_cache.erl:242: type position() is unused
src/file_handle_cache.erl:245: type offset() is unused

The text was updated successfully, but these errors were encountered:

michaelklishin · 2016-06-26T16:21:23Z

The rand module is only available in 18.0+. That's painful.

michaelklishin · 2016-06-26T16:23:35Z

No random:seed functions are used on the hot path so we can introduce a shim module, e.g. rabbit_rand. I don't think we should put in the effort comparable to time_compat and ssl_compat in this case.

michaelklishin · 2016-06-26T16:29:46Z

Actually, now that we have an internal module that does hot swapping for _compat modules, maybe we should do the same thing for rand.

jj1bdx · 2016-06-27T06:49:32Z

If you have compatibility issues, you can use exsplus116 here: https://github.com/jj1bdx/exsplus116

michaelklishin · 2016-06-27T08:37:18Z

@jj1bdx thank you. Is it supposed to be a drop-in replacement for rand?

jj1bdx · 2016-06-27T09:04:39Z

@michaelklishin Same algorithm, does not use anything specific for 18.0 or later.

The old format is removed in Erlang 19.0, leading to build errors. Also, get rid of the `use_specs` macro and thus always define -spec() & friends. While here, unnify the style of -type and -spec. References rabbitmq/rabbitmq-server#860. [#118562897] [#122335241]

Not all `rand` functions are implemented because there is no equivalent in `random`. References rabbitmq/rabbitmq-server#860. [#122335241]

The old format is removed in Erlang 19.0, leading to build errors. Also, get rid of the `use_specs` macro and thus always define -spec() & friends. While here, unnify the style of -type and -spec. References #860. [#118562897] [#122335241]

References #860. [#122335241]

michaelklishin · 2016-06-28T21:12:10Z

Fixed in stable, needs merging into master.

References rabbitmq/rabbitmq-server#860. [#122335241]

The old format is removed in Erlang 19.0, leading to build errors. Also, get rid of the `use_specs` macro and thus always define -spec() & friends. While here, unnify the style of -type and -spec. References rabbitmq/rabbitmq-server#860. [#118562897] [#122335241]

References #860. [#122335241]

The old format is removed in Erlang 19.0, leading to build errors. Also, get rid of the `use_specs` macro and thus always define -spec() & friends. While here, unnify the style of -type and -spec. References rabbitmq/rabbitmq-server#860. [#118562897] [#122335241]

References rabbitmq/rabbitmq-server#860. [#122335241]

The old format is removed in Erlang 19.0, leading to build errors. Also, get rid of the `use_specs` macro and thus always define -spec() & friends. While here, unnify the style of -type and -spec. References rabbitmq/rabbitmq-server#860. [#118562897] [#122335241]

References rabbitmq/rabbitmq-server#860. [#122335241]

The old format is removed in Erlang 19.0, leading to build errors. Also, get rid of the `use_specs` macro and thus always define -spec() & friends. While here, unnify the style of -type and -spec. References rabbitmq/rabbitmq-server#860. [#118562897] [#122335241]

References rabbitmq/rabbitmq-server#860. [#122335241]

The old format is removed in Erlang 19.0, leading to build errors. Also, get rid of the `use_specs` macro and thus always define -spec() & friends. While here, unnify the style of -type and -spec. References rabbitmq/rabbitmq-server#860. [#118562897] [#122335241]

dumbbell · 2016-06-29T15:39:17Z

All repositories pulled by the Umbrella which were using the old -spec format and/or random are fixed.

References rabbitmq/rabbitmq-server#860. [#122335241]

References #860. [#122335241]

The old format is removed in Erlang 19.0, leading to build errors. Also, get rid of the `use_specs` macro and thus always define -spec() & friends. While here, unnify the style of -type and -spec. References rabbitmq/rabbitmq-server#860. [#118562897] [#122335241]

Add missing queue arguments for stream and quorum queues

michaelklishin added bug effort-tiny labels Jun 26, 2016

michaelklishin added this to the 3.6.3 milestone Jun 26, 2016

michaelklishin self-assigned this Jun 26, 2016

michaelklishin added effort-low and removed effort-tiny labels Jun 26, 2016

This was referenced Jun 26, 2016

Compile on OTP 19.0 rabbitmq/rabbitmq-common#111

Merged

Compile on OTP 19.0 #861

Merged

michaelklishin assigned dumbbell and dcorbacho Jun 26, 2016

michaelklishin changed the title ~~Compilation fails on OTP 19.0 because of legacy type specs~~ Compilation fails on OTP 19.0 Jun 26, 2016

michaelklishin modified the milestones: 3.6.4, 3.6.3 Jun 26, 2016

dumbbell added a commit that referenced this issue Jun 28, 2016

Use the new rand_compat module to transition from random to rand

2735990

References #860. [#122335241]

michaelklishin modified the milestones: 3.6.3, 3.6.4 Jun 28, 2016

dumbbell added a commit to rabbitmq/rabbitmq-common that referenced this issue Jun 29, 2016

Fix a few errors in -spec which crept in during the merge of stable

d1e54e6

References rabbitmq/rabbitmq-server#860. [#122335241]

dumbbell added a commit to rabbitmq/rabbitmq-common that referenced this issue Jun 29, 2016

Use rand directly in master because we require Erlang 18.3

2f3b9e7

References rabbitmq/rabbitmq-server#860. [#122335241]

dumbbell added a commit that referenced this issue Jun 29, 2016

Use rand directly in master because we require Erlang 18.3

f0f43f8

References #860. [#122335241]

dumbbell mentioned this issue Jun 29, 2016

Use the new -spec format rabbitmq/rabbitmq-amqp1.0#30

Merged

dumbbell mentioned this issue Jun 29, 2016

Use the new -spec format rabbitmq/rabbitmq-erlang-client#64

Merged

dumbbell added a commit to rabbitmq/rabbitmq-erlang-client that referenced this issue Jun 29, 2016

Use rand directly in master because we require Erlang 18.3

335f252

References rabbitmq/rabbitmq-server#860. [#122335241]

dumbbell mentioned this issue Jun 29, 2016

Use the new rand_compat module to transition from random to rand rabbitmq/rabbitmq-consistent-hash-exchange#23

Merged

dumbbell mentioned this issue Jun 29, 2016

Use the new -spec format rabbitmq/rabbitmq-delayed-message-exchange#61

Merged

dumbbell added a commit to rabbitmq/rabbitmq-federation that referenced this issue Jun 29, 2016

Use the new rand_compat module to transition from random to rand

8ff4eb6

References rabbitmq/rabbitmq-server#860. [#122335241]

dumbbell mentioned this issue Jun 29, 2016

Use the new rand_compat module to transition from random to rand rabbitmq/rabbitmq-federation#36

Merged

dumbbell added a commit to rabbitmq/rabbitmq-federation that referenced this issue Jun 29, 2016

Use rand directly in master because we require Erlang 18.3

b4e1a30

References rabbitmq/rabbitmq-server#860. [#122335241]

dumbbell added a commit to rabbitmq/rabbitmq-management that referenced this issue Jun 29, 2016

Use the new rand_compat module to transition from random to rand

44839df

References rabbitmq/rabbitmq-server#860. [#122335241]

dumbbell mentioned this issue Jun 29, 2016

Use the new rand_compat module to transition from random to rand rabbitmq/rabbitmq-management#238

Merged

dumbbell added a commit to rabbitmq/rabbitmq-management that referenced this issue Jun 29, 2016

Use rand directly in master because we require Erlang 18.3

b57177d

References rabbitmq/rabbitmq-server#860. [#122335241]

dumbbell mentioned this issue Jun 29, 2016

Use the new -spec format rabbitmq/rabbitmq-mqtt#87

Merged

dumbbell added a commit to rabbitmq/rabbitmq-rtopic-exchange that referenced this issue Jun 29, 2016

Use rand directly in master because we require Erlang 18.3

241401f

References rabbitmq/rabbitmq-server#860. [#122335241]

dumbbell added a commit to rabbitmq/rabbitmq-sharding that referenced this issue Jun 29, 2016

Use the new rand_compat module to transition from random to rand

905508f

References rabbitmq/rabbitmq-server#860. [#122335241]

dumbbell mentioned this issue Jun 29, 2016

Use the new rand_compat module to transition from random to rand rabbitmq/rabbitmq-sharding#19

Merged

dumbbell added a commit to rabbitmq/rabbitmq-sharding that referenced this issue Jun 29, 2016

Use rand directly in master because we require Erlang 18.3

2ecaac5

References rabbitmq/rabbitmq-server#860. [#122335241]

dumbbell added a commit to rabbitmq/rabbitmq-shovel that referenced this issue Jun 29, 2016

Use the new rand_compat module to transition from random to rand

5ba07db

References rabbitmq/rabbitmq-server#860. [#122335241]

dumbbell mentioned this issue Jun 29, 2016

Use the new rand_compat module to transition from random to rand rabbitmq/rabbitmq-shovel#16

Merged

dumbbell mentioned this issue Jun 29, 2016

Use the new -spec format rabbitmq/rabbitmq-stomp#86

Merged

dumbbell closed this as completed Jun 29, 2016

dumbbell added a commit to rabbitmq/rabbitmq-consistent-hash-exchange that referenced this issue Jun 30, 2016

Use rand directly in master because we require Erlang 18.3

7710e88

References rabbitmq/rabbitmq-server#860. [#122335241]

dumbbell added a commit that referenced this issue Jun 30, 2016

Use rand directly in master because we require Erlang 18.3

320774f

References #860. [#122335241]

michaelklishin mentioned this issue Jul 5, 2016

Compilation failed on Erlang 19 pma/amqp#28

Closed

dcorbacho pushed a commit that referenced this issue Nov 18, 2020

Merge pull request #860 from rabbitmq/stream-queue-cluster-args

6753759

Add missing queue arguments for stream and quorum queues

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compilation fails on OTP 19.0 #860

Compilation fails on OTP 19.0 #860

michaelklishin commented Jun 26, 2016 •

edited

Loading

michaelklishin commented Jun 26, 2016

michaelklishin commented Jun 26, 2016

michaelklishin commented Jun 26, 2016

jj1bdx commented Jun 27, 2016

michaelklishin commented Jun 27, 2016

jj1bdx commented Jun 27, 2016

michaelklishin commented Jun 28, 2016

dumbbell commented Jun 29, 2016

Compilation fails on OTP 19.0 #860

Compilation fails on OTP 19.0 #860

Comments

michaelklishin commented Jun 26, 2016 • edited Loading

michaelklishin commented Jun 26, 2016

michaelklishin commented Jun 26, 2016

michaelklishin commented Jun 26, 2016

jj1bdx commented Jun 27, 2016

michaelklishin commented Jun 27, 2016

jj1bdx commented Jun 27, 2016

michaelklishin commented Jun 28, 2016

dumbbell commented Jun 29, 2016

michaelklishin commented Jun 26, 2016 •

edited

Loading