Ignore pre-release version part in plugin version requirement validation #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
requested changes
Jan 26, 2017
| is_version_supported(VersionFull, ExpectedVersions) -> | ||
| %% Pre-release version should be supported in plugins, | ||
| %% therefore alpha part should be removed | ||
| Version = remove_version_alpha_part(VersionFull), |
There was a problem hiding this comment.
Let's use "preview" instead of "alpha."
There was a problem hiding this comment.
It's called alpha_info in rabbit_semver
There was a problem hiding this comment.
It's a good opportunity to fix it there. Not all preview versions are alphas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1090
Pre-release version is considered to be less then its basic version by semver semantics (e.g.
3.7.0-alpha.68 < 3.7.0)But plugins should be valid for pre-release versions if version requirements contain release version.
Alpha version part is removed during plugin version check to avoid this inconsistency.