[#103] Specify --parser in Prettier #107
Conversation
|
See also prettier/prettier#13052 |
|
WDYT about the linked PR @raxod502 ? This should also be expanded to handle GraphQL and Markdown |
|
The linked PR has an interesting idea. Since we already have to explicitly support each new major mode, I am not sure if it will actually improve the user experience to adopt that approach versus what I have here. Let me add Markdown and GraphQL as you suggested (subject to #81), then merge this. |
|
Filed ruby-syntax-tree/syntax_tree#144 for an upstream issue I discovered while trying to get CI to pass. |
|
Oh how annoying! |
|
The folks upstream most generously fixed that issue, but apparently the same problem occurs with https://github.com/ruby-syntax-tree/syntax_tree-rbs, which is also a dependency, so I'll submit a pull request for that. |
|
I filed ruby-syntax-tree/syntax_tree-rbs#34, but my Ruby inexperience is showing, unfortunately. |
|
Okay, I fixed up ruby-syntax-tree/syntax_tree-rbs#34 and confirmed that it fixes the CI here, so after that PR is merged, I'll go ahead and rebuild this and it should be good to go. If it takes a long time to merge the upstream PR, then I can adjust the CI here to pull from my branch for now. |
|
Sorry this took so long. But it's done now! |
Closes #103