Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add prettier-json-stringify formatter #183

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add prettier-json-stringify formatter #183

wants to merge 2 commits into from

Conversation

danielpza
Copy link
Contributor

Adds a new formatter for prettier prettier-json-stringify which uses prettier json-stringify parser. json-stringify parser is used by prettier for formatting package.json files

@danielpza danielpza marked this pull request as ready for review March 30, 2023 15:40
@danielpza
Copy link
Contributor Author

I used these changes together with #150 (comment) to make apheleia correctly format package.json files

raxod502
raxod502 reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, mind adding a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raxod502 raxod502 raxod502 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielpza @raxod502