feat: handle bun projects in apheleia-npx #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the formatter test is failing, as this change shouldn't have any impact on previous formatters. Would it be useful for me to add in a test case here for bun? |
|
Could be that a newer version of Prettier formats differently by default, breaking the test, or a bug in Prettier being able to find configuration files correctly. Probably the former. I can look into it in a bit. A new test would be great although the test framework might need to be tweaked a bit to write a good test for this. That is also something I can look at in a bit. Or you can have a go if you feel up to it earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The apheleia-npx script now checks for bun projects and handles them correctly by using the installed bun bin exec the command.