Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testrp and magpie Dockerfiles #7745

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Update testrp and magpie Dockerfiles #7745

merged 1 commit into from
Jul 19, 2024

Conversation

ytimocin
Copy link
Contributor

@ytimocin ytimocin commented Jul 19, 2024 •
edited
Loading

Description

Update testrp and magpie Dockerfiles

Type of change

@ytimocin
Update testrp and magpie Dockerfiles
725b97a 
Signed-off-by: ytimocin <ytimocin@microsoft.com>
@ytimocin ytimocin requested review from a team as code owners July 19, 2024 07:35
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 19, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 725b97a
Unique ID func323d8ebc38
Image tag pr-func323d8ebc38
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func323d8ebc38
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func323d8ebc38
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func323d8ebc38
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func323d8ebc38
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting cli functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

@github-actions GitHub Actions
Copy link

Unit Tests

3 275 tests  ±0   3 269 ✅ ±0   4m 6s ⏱️ +12s
  261 suites ±0       6 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 725b97a. ± Comparison against base commit 2a4effe.

@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.14%. Comparing base (2a4effe) to head (725b97a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7745   +/-   ##
=======================================
  Coverage   61.14%   61.14%           
=======================================
  Files         520      520           
  Lines       27190    27190           
=======================================
  Hits        16624    16624           
  Misses       9101     9101           
  Partials     1465     1465

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rynowak
rynowak approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rynowak
Copy link
Contributor

rynowak commented Jul 19, 2024

@superbeeny this is hopefully the fix for that test issue you ran into it.

@ytimocin ytimocin merged commit 53e19b2 into main Jul 19, 2024
19 checks passed
@ytimocin ytimocin deleted the ytimocin/dockerfileUpdates branch July 19, 2024 17:05
@rynowak rynowak mentioned this pull request Jul 19, 2024
Closed
1 task
sk593 pushed a commit that referenced this pull request Jul 22, 2024
@ytimocin @sk593
Update testrp and magpie Dockerfiles (#7745)
ef56f1b 
# Description
Update testrp and magpie Dockerfiles

## Type of change
- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
Fixes: #7743

Signed-off-by: ytimocin <ytimocin@microsoft.com>
Reshrahim pushed a commit to Reshrahim/radius that referenced this pull request Aug 27, 2024
@ytimocin @Reshrahim
Update testrp and magpie Dockerfiles (radius-project#7745)
13f0ab2 
# Description
Update testrp and magpie Dockerfiles

## Type of change
- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
Fixes: radius-project#7743

Signed-off-by: ytimocin <ytimocin@microsoft.com>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynowak rynowak rynowak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish magpiego as a multi-arch image
2 participants
@ytimocin @rynowak