Add more hidden resources strings #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbzurovski
requested changes
Aug 26, 2024
Comment on lines
61
to
64
| "assetDetails_hideCollection_button": "Hide Collection", | ||
| "assetDetails_hideCollection_title": "Hide Collection", | ||
| "assetDetails_hideCollection_message": "Hide **%s** NFT Collection in your Radix Wallet? You can always unhide it in your account settings." | ||
| "assetDetails_hide_button": "Hide" |
There was a problem hiding this comment.
The following three should apply for this view, and follow the pattern used for hideasset_:
"assetDetails_hideCollection_title": "Hide Collection",
"assetDetails_hideCollection_message": "Hide **%s** NFT Collection in your Radix Wallet? You can always unhide it in your account settings."
"assetDetails_hideCollection_button": "Hide"
Then, the button added here should just be:
"assetDetails_hideCollectionButton": "Hide Collection",
Comment on lines
70
to
71
| "transactionReview_hiddenAsset": "This asset is hidden and will not be visible in your Account", | ||
| "transactionReview_hiddenAssetWithdrawing": "This asset is hidden and is not visible in your Account" |
There was a problem hiding this comment.
Given we haven't merged this code yet, maybe change to:
"transactionReview_hiddenAsset_deposit": "This asset is hidden and will not be visible in your Account",
"transactionReview_hiddenAsset_withdraw": "This asset is hidden and is not visible in your Account"
matiasbzurovski
approved these changes
Aug 26, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.