Various small fixes

radixdlt · Apr 20, 2023 · 7d3c56b · 7d3c56b
1 parent 0ac9c02
commit 7d3c56b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/Sources/Features/AuthorizedDAppsFeature/DappDetails/DappDetails.swift b/Sources/Features/AuthorizedDAppsFeature/DappDetails/DappDetails.swift
@@ -170,15 +170,10 @@ public struct DappDetails: Sendable, FeatureReducer {
 			state.$metadata = metadata
 			return .none
 		case let .dAppUpdated(dApp):
-			guard dApp.dAppDefinitionAddress == state.dApp.dAppDefinitionAddress else {
-				fatalError("Wrong dApp!") // FIXME: Throw error
-			}
+			assert(dApp.dAppDefinitionAddress == state.dApp.dAppDefinitionAddress, "dAppUpdated called with wrong dApp")
 			guard !dApp.detailedAuthorizedPersonas.isEmpty else {
 				return disconnectDappEffect(state: state)
 			}
-//			let previousPersonaDetails = state.personaDetails
-//			state = .init(dApp: dApp, personaDetails: previousPersonaDetails)
-
 			state.dApp = dApp
 
 			return .none

diff --git a/Sources/Features/PersonaDetailsFeature/PersonaDetails.swift b/Sources/Features/PersonaDetailsFeature/PersonaDetails.swift
@@ -117,8 +117,8 @@ public struct PersonaDetails: Sendable, FeatureReducer {
 				return .run { send in
 					let persona = try await personasClient.getPersona(id: persona.id)
 					await send(.internal(.editablePersonaFetched(persona)))
-				} catch: { _, _ in
-					// FIXME: Log/show error?
+				} catch: { error, _ in
+					errorQueue.schedule(error)
 				}
 			}
 

diff --git a/Sources/Features/PersonasFeature/Child/List/PersonaList+Reducer.swift b/Sources/Features/PersonasFeature/Child/List/PersonaList+Reducer.swift
@@ -6,6 +6,7 @@ import PersonasClient
 public struct PersonaList: Sendable, FeatureReducer {
 	@Dependency(\.authorizedDappsClient) var authorizedDappsClient
 	@Dependency(\.personasClient) var personasClient
+	@Dependency(\.errorQueue) var errorQueue
 
 	public struct State: Sendable, Hashable {
 		public var personas: IdentifiedArrayOf<Persona.State>
@@ -67,14 +68,12 @@ public struct PersonaList: Sendable, FeatureReducer {
 		case .task:
 			return .run { [strategy = state.strategy] send in
 				for try await personas in await personasClient.personas() {
-					print("•• Personas \(Task.isCancelled):", personas.map(\.displayName.rawValue))
-
 					let ids = try await personaIDs(strategy) ?? personas.ids
 					let result = ids.compactMap { personas[id: $0] }.map(Persona.State.init)
 					await send(.internal(.personasLoaded(.init(uniqueElements: result))))
 				}
-				print("•• Personas \(Task.isCancelled): DONE")
-			} catch: { _, _ in
+			} catch: { error, _ in
+				errorQueue.schedule(error)
 			}
 
 		case .createNewPersonaButtonTapped: