Don't always reset the portfolio

radixdlt · Oct 9, 2023 · d8c4c37 · d8c4c37
1 parent eee33cb
commit d8c4c37
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/Sources/Features/AccountListFeature/Components/Row/Row+Reducer.swift b/Sources/Features/AccountListFeature/Components/Row/Row+Reducer.swift
@@ -79,9 +79,10 @@ extension AccountList {
 		public func reduce(into state: inout State, viewAction: ViewAction) -> Effect<Action> {
 			switch viewAction {
 			case .task:
-
 				let accountAddress = state.account.address
-				state.portfolio = .loading
+				if state.portfolio.wrappedValue == nil {
+					state.portfolio = .loading
+				}
 
 				checkIfCallActionIsNeeded(state: &state)
 

diff --git a/Sources/Features/AccountPreferencesFeature/Children/DevAccountPreferences+Reducer.swift b/Sources/Features/AccountPreferencesFeature/Children/DevAccountPreferences+Reducer.swift
@@ -259,6 +259,7 @@ public struct DevAccountPreferences: Sendable, FeatureReducer {
 
 		case let .callDone(controlStateKeyPath, changeTo):
 			if controlStateKeyPath == \State.faucetButtonState {
+				// NB: This call to update might be superfluous, since after any transaction we fetch all accounts
 				return updateAccountPortfolio(state).concatenate(with: loadIsAllowedToUseFaucet(&state))
 			} else {
 				state[keyPath: controlStateKeyPath] = changeTo

diff --git a/Sources/Features/HomeFeature/Coordinator/Home.swift b/Sources/Features/HomeFeature/Coordinator/Home.swift
@@ -124,6 +124,10 @@ public struct Home: Sendable, FeatureReducer {
 	public func reduce(into state: inout State, internalAction: InternalAction) -> Effect<Action> {
 		switch internalAction {
 		case let .accountsLoadedResult(.success(accounts)):
+			guard accounts.elements != state.accounts.elements else {
+				return .none
+			}
+
 			state.accountList = .init(accounts: accounts)
 			let accountAddresses = state.accounts.map(\.address)
 			return .run { _ in