Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources and Accounts Fiat worth #1034

Merged

Conversation

GhenadieVP
Copy link
Contributor

@GhenadieVP GhenadieVP commented Feb 19, 2024

Now Wallet displays the Fiat worth for each particular resource as well the Account total fiat worth.

What has been done

  • Introduced the TokenPriceClient to retrieve the prices for each token. Currently only USD is available.
  • Used the new client to calculate the Fiat worth at the moment of composing the AccountPortfolio.
  • Updated how Stakes and Pools are loaded -> now those are fetched in the background as soon user lands on home screen. This is needed, so that we are able to calculate the Account's total Fiat worth, + the total fiat worth across accounts.
  • Integrated the logic for showing/hiding the fiat value, by reading and modifying the respective Profile field.

Demo

homescreen_load.MP4
details_load.MP4
hide_unhide_values.mov

@GhenadieVP GhenadieVP changed the base branch from main to ABW-2589_Transaction-history February 29, 2024 15:54
@GhenadieVP GhenadieVP marked this pull request as ready for review March 1, 2024 10:56
@GhenadieVP GhenadieVP changed the title WIP - Summed holdings of tokens and LSU Resources and Accounts Fiat worth Mar 4, 2024
@kugel3 kugel3 force-pushed the ABW-2589_Transaction-history branch from d88ae65 to d300037 Compare March 10, 2024 10:05
@kugel3 kugel3 force-pushed the ABW-2589_Transaction-history branch 4 times, most recently from 2e9efcc to 5e4e672 Compare March 15, 2024 12:04
Base automatically changed from ABW-2589_Transaction-history to main March 15, 2024 12:57
@GhenadieVP GhenadieVP merged commit 939f698 into main Mar 15, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the fix/ABW-2696-i-os-account-view-display-of-summed-holdings branch March 15, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants