Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ROLA completion slide up #1040

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix ROLA completion slide up #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions RadixWallet/Features/DappInteractionFeature/Children/Completion/Completion.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ struct Completion: Sendable, FeatureReducer {
case dismissTapped
}

@Dependency(\.dismiss) var dismiss
enum DelegateAction: Sendable, Equatable {
case dismiss
}

func reduce(into state: inout State, viewAction: ViewAction) -> Effect<Action> {
switch viewAction {
case .dismissTapped:
.run { _ in
await dismiss()
}
.send(.delegate(.dismiss))
}
}
}
9 changes: 3 additions & 6 deletions RadixWallet/Features/DappInteractionFeature/Interactor/DappInteractor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,12 +274,9 @@ struct DappInteractor: Sendable, FeatureReducer {
return delayedMediumEffect(internal: .presentQueuedRequestIfNeeded)
}

case .modal(.dismiss):
if case .dappInteractionCompletion = state.currentModal {
return delayedMediumEffect(internal: .presentQueuedRequestIfNeeded)
}

return .none
case .modal(.presented(.dappInteractionCompletion(.delegate(.dismiss)))):
state.currentModal = nil
return delayedMediumEffect(internal: .presentQueuedRequestIfNeeded)

default:
return .none
Expand Down
Loading