Avoid crashing for RETDecimal.max().formated(...) #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sajjon
reviewed
Mar 14, 2024
|
|
||
| try doTest(RETDecimal.max(), expected: "3.138e39") |
There was a problem hiding this comment.
this is a new test, which fails on main branch, but not anymore.
Sajjon
reviewed
Mar 14, 2024
| // `toZero` to avoid overflow. | ||
| let safeBase = try! base.round( | ||
| decimalPlaces: Int32(decimalPlaces), | ||
| roundingMode: .toZero |
There was a problem hiding this comment.
N.B. .toNearestMidpointTowardZero will not work either, must be .toZero.
kugel3
reviewed
Mar 14, 2024
| @@ -246,7 +246,23 @@ extension RETDecimal { | |||
| let integerCount = UInt(Swift.max(digits.count - RETDecimal.scale, 1)) | |||
| if integerCount > totalPlaces { | |||
| let scale = RETDecimal(exponent: integerCount - totalPlaces) | |||
| return (self / scale).rounded(decimalPlaces: 0) * scale | |||
| let base = self / scale | |||
There was a problem hiding this comment.
I would say that we don't want to protect ourselves against any kind of error here, only the specific case of max, no? We could just
guard self != max else {
// return the number rounded towards zero
}
There was a problem hiding this comment.
No because if the value is close to max we don't want to fail either. Hmm
GhenadieVP
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: paste link here
Complements / depends on / relates to #link to other PR
Description
This PR solves / fixes / adds / includes functionality 1 and functionality 2.
Notes
Additional notes.
How to test
Happy path (or test variation 1)
Unhappy path (or test variation 2)
Screenshot
Video
paste link here
PR submission checklist