Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failed message for Guarantees #1048

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Assertion failed message for Guarantees #1048

merged 4 commits into from
Mar 15, 2024

Conversation

GhenadieVP
Copy link
Contributor

Description

Identify and display the proper error message for assertion failed errors.

How to test

Happy path (or test variation 1)

  1. Execute tx with guarantees > 100%
  2. Observe failure message

Video

RPReplay_Final1710497033.MP4

Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GhenadieVP GhenadieVP merged commit 2b7449a into main Mar 15, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the guarantees_error branch March 15, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants