[ABW-2589] Transaction History Part Deux #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel3
force-pushed
the
ABW-2589_Transaction-history-part-deux
branch
4 times, most recently
from
4fe4888
to
f09bb4b
Compare
kugel3
force-pushed
the
ABW-2589_Transaction-history-part-deux
branch
from
daa0daf
to
0dfa306
Compare
GhenadieVP
reviewed
Mar 22, 2024
| @@ -55,7 +55,7 @@ extension TransactionReviewAccount.State { | |||
| extension TransactionReviewAccount { | |||
| public struct ViewState: Equatable { | |||
| let account: TransactionReview.Account | |||
| let transfers: [ResourceBalance] // FIXME: GK use viewstate? | |||
| let transfers: [TransactionReview.Transfer] // FIXME: GK use viewstate? | |||
GhenadieVP
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: paste link here
Complements / depends on / relates to #link to other PR
Description
This PR solves / fixes / adds / includes functionality 1 and functionality 2.
Notes
Additional notes.
How to test
Happy path (or test variation 1)
Unhappy path (or test variation 2)
Screenshot
Video
paste link here
PR submission checklist