Home Screen load laggines #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhenadieVP
commented
Mar 19, 2024
RadixWallet/Clients/AccountPortfoliosClient/AccountPortfoliosClient+State.swift
Show resolved
Hide resolved
GhenadieVP
commented
Mar 19, 2024
GhenadieVP
commented
Mar 19, 2024
RadixWallet/Features/HomeFeature/Children/AccountRow/Home+AccountRow+Reducer.swift
Outdated
Show resolved
Hide resolved
GhenadieVP
commented
Mar 19, 2024
Sajjon
reviewed
Mar 19, 2024
RadixWallet/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Mock.swift
Outdated
Show resolved
Hide resolved
Sajjon
reviewed
Mar 19, 2024
RadixWallet/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Mock.swift
Outdated
Show resolved
Hide resolved
CyonAlexRDX
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce the slowness of loading the home screen.
After introducing fiatWorth on home screen, there are many more events which do trigger the updated of the state.
TCA seems to have issues when many actions are emitted in quick-ish succession, it has high impact on the main thread since all of the actions are resolved on the main thread.
There is still a small lag with this, potentially SharedState would help resolve this.
Loading Before
RPReplay_Final1710851174.MP4
Loading After
RPReplay_Final1710851060.MP4
#CPU load before
CPU load after