-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bunch of bugs #1054
A bunch of bugs #1054
Conversation
I have a better solution for the id, ResourceBalance shouldn't be ID:ed at all really, it's only in the TransactionReview context that we use that, and that's really only so that we can apply guarantees. I use About the other bugs, what are they? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied the proper forcerRefresh.
@@ -4,7 +4,7 @@ public typealias TXID = TransactionHash | |||
|
|||
extension TXID { | |||
public func formatted(_ format: AddressFormat = .default) -> String { | |||
bytes().hex() | |||
asStr() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properly formatted TXID
@@ -77,7 +77,7 @@ public struct AssetTransfer: Sendable, FeatureReducer { | |||
let manifest = try await createManifest(accounts) | |||
Task { | |||
_ = try await dappInteractionClient.addWalletInteraction( | |||
.transaction(.init(send: .init(transactionManifest: manifest))), | |||
.transaction(.init(send: .init(transactionManifest: manifest, message: message))), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Message was removed in some of older PRs
@@ -90,11 +90,11 @@ private extension View { | |||
private func addAsset(with destinationStore: PresentationStoreOf<TransferAccountList.Destination>) -> some View { | |||
sheet(store: destinationStore.scope(state: \.state.addAsset, action: \.addAsset)) { assetsStore in | |||
AssetsView.View(store: assetsStore) | |||
.navigationTitle(L10n.AssetTransfer.AddAssets.navigationTitle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With latest iOS updates the order matters now.
Several small bug fixes: