Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of bugs #1054

Merged
merged 13 commits into from
Mar 22, 2024
Merged

A bunch of bugs #1054

merged 13 commits into from
Mar 22, 2024

Conversation

GhenadieVP
Copy link
Contributor

@GhenadieVP GhenadieVP commented Mar 20, 2024

Several small bug fixes:

@kugel3
Copy link
Contributor

kugel3 commented Mar 20, 2024

I have a better solution for the id, ResourceBalance shouldn't be ID:ed at all really, it's only in the TransactionReview context that we use that, and that's really only so that we can apply guarantees. I use Identified<ResourceBalance> there instead, and remove the id from ResourceBalance. Using the resource address is not enough, since there are situations where you can have lists where the same resource appears multiple times, etc.

About the other bugs, what are they?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied the proper forcerRefresh.

@@ -4,7 +4,7 @@ public typealias TXID = TransactionHash

extension TXID {
public func formatted(_ format: AddressFormat = .default) -> String {
bytes().hex()
asStr()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properly formatted TXID

@@ -77,7 +77,7 @@ public struct AssetTransfer: Sendable, FeatureReducer {
let manifest = try await createManifest(accounts)
Task {
_ = try await dappInteractionClient.addWalletInteraction(
.transaction(.init(send: .init(transactionManifest: manifest))),
.transaction(.init(send: .init(transactionManifest: manifest, message: message))),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message was removed in some of older PRs

@@ -90,11 +90,11 @@ private extension View {
private func addAsset(with destinationStore: PresentationStoreOf<TransferAccountList.Destination>) -> some View {
sheet(store: destinationStore.scope(state: \.state.addAsset, action: \.addAsset)) { assetsStore in
AssetsView.View(store: assetsStore)
.navigationTitle(L10n.AssetTransfer.AddAssets.navigationTitle)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With latest iOS updates the order matters now.

@GhenadieVP GhenadieVP marked this pull request as ready for review March 21, 2024 11:04
@GhenadieVP GhenadieVP merged commit 455e206 into main Mar 22, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the bugs branch March 22, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants