Another round of bug fixing #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhenadieVP
commented
Mar 25, 2024
| @@ -259,7 +259,7 @@ extension ResourceBalanceView { | |||
| VStack(alignment: .leading, spacing: .zero) { | |||
| FungibleView( | |||
| thumbnail: .poolUnit(viewState.poolIcon), | |||
| caption1: viewState.poolName ?? L10n.TransactionReview.poolUnits, | |||
There was a problem hiding this comment.
No fallback for poolUnits name
GhenadieVP
commented
Mar 25, 2024
| @@ -465,7 +465,7 @@ extension ResourceBalanceView { | |||
| } | |||
|
|
|||
| private var useSpacer: Bool { | |||
| amount != nil || fallback != nil | |||
| amount != nil || fallback != nil || caption1 == nil | |||
There was a problem hiding this comment.
Spacer required for the case of missing caption1 and the checkmark selection needs to be disaplyed.
GhenadieVP
commented
Mar 25, 2024
| @@ -96,7 +110,7 @@ extension SubmitTransaction { | |||
| viewStore.send(.appeared) | |||
| } | |||
| .alert(store: store.scope(state: \.$dismissTransactionAlert, action: { .view(.dismissTransactionAlert($0)) })) | |||
| .interactiveDismissDisabled(true) | |||
There was a problem hiding this comment.
Probably was left in after some local testing
danvleju-rdx
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small round of bug fixing for this release, including the above tickets, but also other reported in the slack channel.