Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3026] Account settings XRD faucet placement #1061

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

danvleju-rdx
Copy link
Contributor

@danvleju-rdx danvleju-rdx commented Mar 26, 2024

Jira ticket: ABW-3026

Description

Moved “Get XRD Tokens“ button from Development Preferences to AccountSettings screen

Video

Screen.Recording.2024-03-26.at.10.35.45.mov

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all the buttons here are only for debug mode, I could have removed all #DEBUG checks. However, there may be buttons for non-debug mode in the future, so I decided to leave them. Let me know what you think.

Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@GhenadieVP GhenadieVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the Dev Preferences section should be hidden completely on mainnet, non-Debug builds? need to double-check.

All good 👍.

Copy link
Contributor

@GhenadieVP GhenadieVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@GhenadieVP GhenadieVP added the DO NOT MERGE Merging is blocked or prohibited due to missing specs or other higher priority PRs label Mar 26, 2024
@GhenadieVP GhenadieVP removed the DO NOT MERGE Merging is blocked or prohibited due to missing specs or other higher priority PRs label Apr 4, 2024
@GhenadieVP GhenadieVP merged commit a4c800a into main Apr 4, 2024
5 checks passed
@GhenadieVP GhenadieVP deleted the ABW-3026-account-settings-xrd-faucet-placement branch April 4, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants