Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3022] Copy address icon colour #1062

Merged

Conversation

danvleju-rdx
Copy link
Contributor

@danvleju-rdx danvleju-rdx commented Mar 26, 2024

Jira ticket: ABW-3022

Description

Changed the copy address icon color wherever it was incorrect.

@GhenadieVP GhenadieVP added the DO NOT MERGE Merging is blocked or prohibited due to missing specs or other higher priority PRs label Mar 26, 2024
@@ -6,21 +6,21 @@ struct KeyValueView<Content: View>: View {
let key: String
let content: Content

init(resourceAddress: ResourceAddress) where Content == AddressView {
init(resourceAddress: ResourceAddress, imageColor: Color?) where Content == AddressView {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we mostly use .app.gray2 ? should we maybe default to that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point 👍

Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GhenadieVP GhenadieVP removed the DO NOT MERGE Merging is blocked or prohibited due to missing specs or other higher priority PRs label Apr 4, 2024
@GhenadieVP GhenadieVP merged commit a48f4ae into main Apr 4, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the ABW-3022-asset-details-copy-address-icon-is-the-wrong-colour branch April 4, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants