Fixes round 3 #1063
Merged
Fixes round 3 #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhenadieVP
commented
Mar 26, 2024
| @@ -68,6 +68,9 @@ extension AssetsView { | |||
| } | |||
| } | |||
| } | |||
| #if !DEBUG | |||
There was a problem hiding this comment.
In DEBUG the default value will be used, which is false. So Fiat value will always be shown in DEBUG mode.
GhenadieVP
commented
Mar 26, 2024
| @@ -465,7 +468,7 @@ extension ResourceBalanceView { | |||
| } | |||
|
|
|||
| private var useSpacer: Bool { | |||
| amount != nil || fallback != nil || caption1 == nil | |||
There was a problem hiding this comment.
Wasn't a good place for the fix, it did push out completely the text field for amount entry.
CyonAlexRDX
reviewed
Mar 26, 2024
| @@ -15,6 +15,12 @@ extension ResourceAddress { | |||
| static let mainnetXRDAddress: ResourceAddress = .xrd(on: .mainnet) | |||
| } | |||
|
|
|||
| extension SpecificAddress { | |||
| var isOnMainnet: Bool { | |||
| networkID == NetworkID.mainnet | |||
There was a problem hiding this comment.
Please out put this in another file. Please :D RadixWallet/EngineKit/ is verboten! :D
There was a problem hiding this comment.
ohh yes, forgoten it is verboten :D
CyonAlexRDX
approved these changes
Mar 26, 2024
danvleju-rdx
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final-final-v6 round of bug fixing...
Fix for AdHoc reported bugs:
Demo
RPReplay_Final1711463312.MP4