Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-3101] Account transfer tappable areas adjustments #1065

Merged
merged 3 commits into from
Apr 4, 2024
Merged

[ABW-3101] Account transfer tappable areas adjustments #1065

merged 3 commits into from
Apr 4, 2024

Conversation

danvleju-rdx
Copy link
Contributor

@danvleju-rdx danvleju-rdx commented Mar 27, 2024 •
edited by jira bot
Loading

Jira ticket: ABW-3101

Description

What was done:

  • Make the "Choose Account" tappable area the entire card header, rather than just the text
  • Make the "Add Assets" tappable area a mostly full-width invisible "button" in that part of the card, rather than just the text
  • Make the "Add Transfer tappable area a larger invisible button, rather than just the text
  • Make the "Choose Account" and "Add Assets" text blue like the other similar text buttons
  • Add a small icon to Choose Account and Add Assets

Screenshot

Screen 1 Before Screen 1 After
Simulator Screenshot - iPhone 15 Pro - 2024-03-27 at 11 37 25 Simulator Screenshot - iPhone 15 Pro - 2024-03-27 at 11 37 52

|

@danvleju-rdx danvleju-rdx added the DO NOT MERGE Merging is blocked or prohibited due to missing specs or other higher priority PRs label Mar 27, 2024
danvleju-rdx
danvleju-rdx commented Mar 27, 2024
View reviewed changes
...tTransferFeature/Components/TransferAccountList/ReceivingAccount/ReceivingAccount+View.swift
viewStore.send(.addAssetTapped)
} label: {
Text(L10n.AssetTransfer.ReceivingAccount.addAssetsButton)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ character will be inside the message

CyonAlexRDX
CyonAlexRDX approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM!

@GhenadieVP GhenadieVP removed the DO NOT MERGE Merging is blocked or prohibited due to missing specs or other higher priority PRs label Apr 4, 2024
@GhenadieVP GhenadieVP merged commit 75d00c5 into main Apr 4, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the ABW-3101-account-transfer-tappable-areas branch April 4, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

@GhenadieVP GhenadieVP GhenadieVP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danvleju-rdx @CyonAlexRDX @GhenadieVP