Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3021] Close button placement on sheets #1067

Merged
merged 4 commits into from
Apr 8, 2024
Merged

[ABW-3021] Close button placement on sheets #1067

merged 4 commits into from
Apr 8, 2024

Conversation

matiasbzurovski
Copy link
Contributor

@matiasbzurovski matiasbzurovski commented Apr 1, 2024

Jira ticket: ABW-3021

Description

Places the CloseButton always on the leading side of the navigation bar of every sheet that includes it.

Screenshot

Before After
Simulator Screenshot - iPhone 15 Pro - 2024-04-01 at 14 52 25 Simulator Screenshot - iPhone 15 Pro - 2024-04-01 at 14 56 17
Simulator Screenshot - iPhone 15 Pro - 2024-04-01 at 14 53 25 Simulator Screenshot - iPhone 15 Pro - 2024-04-01 at 14 56 21
Simulator Screenshot - iPhone 15 Pro - 2024-04-01 at 14 53 37 Simulator Screenshot - iPhone 15 Pro - 2024-04-01 at 14 56 31

@matiasbzurovski matiasbzurovski added the DO NOT MERGE Merging is blocked or prohibited due to missing specs or other higher priority PRs label Apr 1, 2024
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure about this one, sometimes we want both a back button and a close button, for modally presented flows. Have you verified that those still work, i.e. that you can both go back and close?

@matiasbzurovski
Copy link
Contributor Author

matiasbzurovski commented Apr 4, 2024

I haven't seen any flow like that (back button on leading, close button on trailing). In fact, I would even say that it isn't a desired UX to have.
Do you have any example I can check @CyonAlexRDX ?

@CyonAlexRDX
Copy link
Contributor

@matiasbzurovski i can't find it either now - so maybe we have long since removed that. But worth raising with Matt! Eg create persona flow - it is a modally presented flow, after first "intro screen" in the flow we push "name persona screen", from which we can (have in the past?) have a back button on left in nav bar and a close button on the right.

@matiasbzurovski
Copy link
Contributor Author

@CyonAlexRDX Aftab approved this change on Slack 👍

Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matiasbzurovski matiasbzurovski merged commit 5c2a074 into main Apr 8, 2024
6 checks passed
@matiasbzurovski matiasbzurovski deleted the abw-3021 branch April 8, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Merging is blocked or prohibited due to missing specs or other higher priority PRs
Development

Successfully merging this pull request may close these issues.

3 participants