-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ABW-3021] Close button placement on sheets #1067
Conversation
… the cancellationAction placement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure about this one, sometimes we want both a back button and a close button, for modally presented flows. Have you verified that those still work, i.e. that you can both go back and close?
I haven't seen any flow like that (back button on leading, close button on trailing). In fact, I would even say that it isn't a desired UX to have. |
@matiasbzurovski i can't find it either now - so maybe we have long since removed that. But worth raising with Matt! Eg create persona flow - it is a modally presented flow, after first "intro screen" in the flow we push "name persona screen", from which we can (have in the past?) have a back button on left in nav bar and a close button on the right. |
@CyonAlexRDX Aftab approved this change on Slack 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jira ticket: ABW-3021
Description
Places the
CloseButton
always on the leading side of the navigation bar of every sheet that includes it.Screenshot