[ABW-2735] AppsFlyer integration #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbzurovski
commented
Apr 4, 2024
GhenadieVP
reviewed
Apr 4, 2024
RadixWallet/Clients/SensitiveInfoClient/SensitiveInfoClient+Live.swift
Outdated
Show resolved
Hide resolved
RadixWallet/Clients/SensitiveInfoClient/SensitiveInfoClient+Live.swift
Outdated
Show resolved
Hide resolved
GhenadieVP
reviewed
Apr 4, 2024
GhenadieVP
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-2735
Description
Adds AppsFlyer support.
Notes
The AppsFlyer logic is very simple, but this PR also includes a solution for handling sensitive information (such as AppsFlyer tokens). To do so, the app has a new
SensitiveInfoClientthat will fetch the values for each key specified on its interface.The file from which the app will read its values is called
SensitiveInfo.plist. Given its content is sensitive, it has been added to the.gitgnoreso that its content is never committed. However, a sample file (with placeholder values) has been added, and a custom run script phase will make sure to create theSensitiveInfofile from the sample one if it doesn't exist.Then, on CD, we will replace the placeholder values with the real ones that are safely stored on secrets.