Remove the usage of crashing initialiser of IdentifiedArray #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
reviewed
Apr 8, 2024
| @@ -16,21 +16,21 @@ final class GatewaySettingsFeatureTests: TestCase { | |||
|
|
|||
| func test_whenViewAppeared_thenCurrentGatewayAndGatewayListIsLoaded() async throws { | |||
| // given | |||
| let otherGateways: [Radix.Gateway] = [.stokenet, .rcnet] | |||
| let otherGateways: [Radix.Gateway] = [.stokenet, .rcnet].asIdentifiable() | |||
There was a problem hiding this comment.
use validating instead, which is throwing, and we are in a throwing context
CyonAlexRDX
reviewed
Apr 8, 2024
| @@ -79,16 +79,16 @@ final class GatewaySettingsFeatureTests: TestCase { | |||
| func test_whenNonCurrentGatewayRemovalIsConfirmed_removeGateway() async throws { | |||
| // given | |||
| let gatewayToBeDeleted = GatewayRow.State(gateway: .rcnet, isSelected: false, canBeDeleted: true) | |||
| let otherGateways: [Radix.Gateway] = [.stokenet, .rcnet] | |||
| let otherGateways: [Radix.Gateway] = [.stokenet, .rcnet].asIdentifiable() | |||
CyonAlexRDX
reviewed
Apr 8, 2024
| @@ -141,7 +141,7 @@ public struct PersonasCoordinator: Sendable, FeatureReducer { | |||
| return .run { send in | |||
| let dApps = try await authorizedDappsClient.getDappsAuthorizedByPersona(persona.id) | |||
| .map(PersonaDetails.State.DappInfo.init) | |||
| let personaDetailsState = PersonaDetails.State(.general(persona, dApps: .init(uniqueElements: dApps))) | |||
| let personaDetailsState = PersonaDetails.State(.general(persona, dApps: dApps.asIdentifiable())) | |||
There was a problem hiding this comment.
should maybe use validating here, since it is a throwing context, and we wanna find those bugs...
CyonAlexRDX
reviewed
Apr 8, 2024
| @@ -74,7 +74,7 @@ public struct PersonaList: Sendable, FeatureReducer { | |||
| guard result.count == ids.count else { | |||
| throw UpdatePersonaError.personasMissingFromClient(ids.subtracting(result.map(\.id))) | |||
| } | |||
| await send(.internal(.personasLoaded(.init(uniqueElements: result)))) | |||
| await send(.internal(.personasLoaded(result.asIdentifiable()))) | |||
There was a problem hiding this comment.
validating instead I think
CyonAlexRDX
reviewed
Apr 8, 2024
| @@ -286,7 +286,7 @@ public struct PersonaDetails: Sendable, FeatureReducer { | |||
| let dApps = try await authorizedDappsClient.getDappsAuthorizedByPersona(oldPersona.id) | |||
| .map(State.DappInfo.init) | |||
|
|
|||
| return await .general(persona, dApps: addingDappMetadata(to: .init(uniqueElements: dApps))) | |||
| return await .general(persona, dApps: addingDappMetadata(to: dApps.asIdentifiable())) | |||
There was a problem hiding this comment.
maybe validating here too
CyonAlexRDX
reviewed
Apr 8, 2024
| @@ -266,7 +266,7 @@ struct DappInteractionFlow: Sendable, FeatureReducer { | |||
| setAccountsResponse( | |||
| to: ongoingAccountsWithoutProofOfOwnership.requestItem, | |||
| accessKind: .ongoing, | |||
| chosenAccounts: .withoutProofOfOwnership(.init(uniqueElements: ongoingAccountsWithoutProofOfOwnership.accounts)), | |||
| chosenAccounts: .withoutProofOfOwnership(ongoingAccountsWithoutProofOfOwnership.accounts.asIdentifiable()), | |||
There was a problem hiding this comment.
maybe validating here ? if we can throw, not sure.
CyonAlexRDX
reviewed
Apr 8, 2024
| lastLogin: persona == lastLoggedInPersona ? authorizedPersonaSimple?.lastLogin : nil | ||
| ) | ||
| } | ||
| .asIdentifiable() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://radixdlt.atlassian.net/browse/ABW-3148
Description
We have several crash reports relating to transaction that did contain proofs, and a problems seem to be having multiple identical proofs which caused the app to crash:
The problem was the usage of the crashing initialiser of IdentifiedArray. I went a bit overboard and replaced all these usages with safe
asIdentifiable.