[AVW-2908] Transaction Review Header #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel3
changed the title
|
How does it look for incoming transactions from a dApp? it should be like this |
|
Well it doesn't look like that, I am just using the navigationTitle property. Will try to use a toolbar item instead |
|
Now it looks like that... |
GhenadieVP
approved these changes
Apr 9, 2024
| @@ -1,5 +1,4 @@ | |||
| { | |||
| "originHash" : "3313f884630244f405efa4cdbbcb2486d097b16289931114ea3c6826384f24b9", | |||
| @@ -15,8 +14,8 @@ | |||
| "kind" : "remoteSourceControl", | |||
| "location" : "https://github.com/AppsFlyerSDK/AppsFlyerFramework-Strict", | |||
| "state" : { | |||
| "revision" : "a22ea3af34d4631123bd54f55f95f7b7a9cd905f", | |||
| "version" : "6.13.2" | |||
| "revision" : "f9e6a597252ab719805033a7912c64d2dd1f077e", | |||
kugel3
force-pushed
the
ABW-2908_Review-Transaction-header
branch
from
219f3a4
to
e1b8e85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-2908
Description
Show the title in the navigation bar in Transaction Review, when scrolling away the other title.
Notes
We could do the same thing in other places too, like the home screen, it's fairly painless.
How to test
Screenshot
Video
TxReview.mov
PR submission checklist