Fix 400 error in transaction history #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel3
force-pushed
the
fix/400-error-in-transaction-history
branch
from
e5c2b8e
to
4b86ef5
Compare
GhenadieVP
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack discussion: thread
Description
Some users have experienced an HTTP error, that may be due to them having their clock going a little fast. When we make the requests in transaction history, the Gateway will complain if the upper bound date is more than a few seconds into the future.
This PR removes the upper bound when it would have otherwise been now.
I tested setting the clock forward and on main that does cause the 400 error, and it is indeed fixed by this PR.
It also improves the handling when there are no transactions at all.
PR submission checklist