Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-dump version bump #1084

Merged
merged 2 commits into from
Apr 11, 2024
Merged

custom-dump version bump #1084

merged 2 commits into from
Apr 11, 2024

Conversation

GhenadieVP
Copy link
Contributor

@GhenadieVP GhenadieVP commented Apr 11, 2024

swift-custom-dump is transient dependency, had to pin in Package.resolved.
Fixes the build error in Release mode - pointfreeco/swift-custom-dump#108

Copy link
Contributor

@matiasbzurovski matiasbzurovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I don't see any changes in the project.pbxproj, I assume you manually changed the Package.resolved file.

This should work for the next archive, but if we ever resolve packages/add a new package, we will introduce this issue again. I think we should manually add swift-custom-dump as a dependency of our project and point it to this exact version.

@GhenadieVP GhenadieVP merged commit 1244071 into main Apr 11, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the bump_custom_dump branch April 11, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants